Update non-core module "queue"
Bug #1188062 reported by
Chris Hillery
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zorba |
Fix Released
|
Critical
|
Luis Rodriguez Gonzalez |
Bug Description
Update non-core module "queue". Refer to the Zorba 3.0 Module Update Checklist at http://
This minimally means renaming the module to the "http://
Related branches
lp:~zorba-coders/zorba/bug-1188062
- Luis Rodriguez Gonzalez: Approve
- Chris Hillery: Approve
-
Diff: 546 lines (+181/-72)29 files modifiedsrc/CMakeLists.txt (+1/-1)
src/queue.xq (+60/-58)
test/ExpQueryResults/back-json1.xml.res (+1/-0)
test/ExpQueryResults/copy-json1.xml.res (+1/-0)
test/ExpQueryResults/empty-json1.xml.res (+2/-0)
test/ExpQueryResults/front-json1.xml.res (+1/-0)
test/ExpQueryResults/pop-json2.xml.res (+1/-0)
test/ExpQueryResults/pop-mix.xml.res (+1/-0)
test/ExpQueryResults/push-json1.xml.res (+1/-0)
test/ExpQueryResults/push-json2.xml.res (+1/-0)
test/ExpQueryResults/size-json1.xml.res (+2/-0)
test/Queries/back-json1.xq (+7/-0)
test/Queries/back1.xq (+2/-2)
test/Queries/copy-json1.xq (+11/-0)
test/Queries/copy1.xq (+1/-1)
test/Queries/empty-json1.xq (+20/-0)
test/Queries/empty1.xq (+1/-1)
test/Queries/front-json1.xq (+7/-0)
test/Queries/front1.xq (+2/-2)
test/Queries/pop-json2.xq (+7/-0)
test/Queries/pop-mix.xq (+9/-0)
test/Queries/pop1.xq (+2/-2)
test/Queries/pop2.xq (+2/-2)
test/Queries/push-json1.xq (+12/-0)
test/Queries/push-json2.xq (+13/-0)
test/Queries/push1.xq (+1/-1)
test/Queries/push2.xq (+1/-1)
test/Queries/size-json1.xq (+10/-0)
test/Queries/size1.xq (+1/-1)
Changed in zorba: | |
assignee: | nobody → Luis Rodriguez Gonzalez (kuraru) |
importance: | Undecided → High |
milestone: | none → 3.0 |
status: | New → Confirmed |
description: | updated |
tags: | added: module-cleanup |
summary: |
- This is my summary + Update non-core module "queue" |
Changed in zorba: | |
importance: | High → Critical |
Changed in zorba: | |
status: | Confirmed → In Progress |
Changed in zorba: | |
status: | In Progress → Fix Committed |
Changed in zorba: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Per Matthias, it makes sense to update this module to be JSONiq-friendly as well. Currently it only supports node items (which are only XML), but there's no real reason to limit it this way.
All the functions that accept or return "node()" should be changed to accept/return "structured- item()" . (structured-item() means "node, JSON object, or JSON array".)
Also, currently the stack module implementation is using node-specific functions in the DML libraries. Those functions are being deprecated and replaced with more general item-based functions. For instance, instead of dml:delete- nodes-first( ), use the dml:delete() function which takes an item() rather than a node() argument.