Zorba

Certain regexes involving ^ should be legal

Bug #1132032 reported by Chris Hillery
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zorba
Fix Released
Medium
Paul J. Lucas
Zorba 2.9 "Io"

Bug Description

The test cases string/Regex/regex_err7.xq and string/Regex/regex_err25.xq both currently raise FORX0002, meaning the pattern is invalid. However, as far as I can tell, the pattern in both cases (^^ and a^ respectively) are both legal, although they can never match any input. The expected result of both tests should be "false", not an error.

Related branches

lp:~zorba-coders/zorba/bug-1123161
Chris Hillery: Approve
Paul J. Lucas: Approve
Matthias Brantner: Approve
Diff: 922 lines (+383/-229)
12 files modified
ChangeLog (+6/-2)
src/diagnostics/diagnostic_en.xml (+18/-2)
src/diagnostics/pregenerated/dict_en.cpp (+10/-0)
src/diagnostics/pregenerated/dict_zed_keys.h (+5/-1)
src/util/ascii_util.cpp (+11/-5)
src/util/regex.cpp (+321/-108)
test/fots/CMakeLists.txt (+9/-106)
test/rbkt/ExpQueryResults/zorba/string/Regex/regex_m54.xml.res (+1/-0)
test/rbkt/ExpQueryResults/zorba/string/Regex/regex_m55.xml.res (+1/-0)
test/rbkt/Queries/CMakeLists.txt (+1/-3)
test/rbkt/Queries/zorba/string/Regex/regex_err25.spec (+0/-1)
test/rbkt/Queries/zorba/string/Regex/regex_err7.spec (+0/-1)
Chris Hillery (ceejatec)
Changed in zorba:
assignee: nobody → Paul J. Lucas (paul-lucas)
importance: Undecided → Medium
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: New → In Progress
milestone: none → 2.9
summary: - Certain weird regexes should be legal
+ Certain regexes involving ^ should be legal
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: In Progress → Fix Committed
Chris Hillery (ceejatec)
Changed in zorba:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.