testdriver doesn't handler Iterator returning false

[Paul J. Lucas]

In testdriver_common.cpp, line 437, there is:

  lIter->next(lDoc);

This is wrong since it doesn't check the return value of next in case it's false. I don't know what it should do for false, but it definitely shouldn't attempt to use lDoc.

[Paul J. Lucas (paul-lucas)]

FYI: This was a contributing cause to my libxml2 error troubles.

[Chris Hillery (ceejatec)]

Paul - if possible, give me some more information about how this caused trouble, preferably with a way to reproduce bad behaviour. If it's simple code-cleanliness then I need to lower the priority.

[Paul J. Lucas (paul-lucas)]

As I mentioned in my first note, it's a real problem. I don't have an example handy, but I would guess that you provide some invalid XML.

[Chris Hillery (ceejatec)]

Your first note just says that it caused problems, not what those problems were. I don't really know this code either and I don't have time to try and invent a test case. For now I'm removing the 3.0 milestone and lowering the priority, but leaving it assigned to you as Incomplete.