Timezone units as hours are wrong
Bug #1103115 reported by
Paul J. Lucas
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zorba |
Fix Committed
|
High
|
Paul J. Lucas |
Bug Description
In src/store/
Both the API and the way in which timezone offsets are stored internally must be changed to at LEAST minutes, but, IMHO, might as well make it seconds to match the way Unix does it. In this case, the timezone would have to be stored as at least an "int." Additionally, positive values should always indicate locations east of Greenwich.
If this is going to be fixed, it ought to be for 3.0 when we can break stuff.
Related branches
lp:~zorba-coders/zorba/bug-1103115
- Matthias Brantner: Approve
- Paul J. Lucas: Approve
-
Diff: 1341 lines (+434/-330)20 files modifiedChangeLog (+1/-0)
include/zorba/dynamic_context.h (+4/-3)
include/zorba/item_factory.h (+6/-6)
src/api/itemfactoryimpl.cpp (+6/-8)
src/api/itemfactoryimpl.h (+3/-3)
src/context/dynamic_context.cpp (+1/-1)
src/runtime/datetime/datetime_impl.cpp (+5/-5)
src/runtime/durations_dates_times/format_dateTime.cpp (+2/-2)
src/store/api/item_factory.h (+9/-6)
src/store/naive/simple_item_factory.cpp (+6/-6)
src/store/naive/simple_item_factory.h (+3/-3)
src/util/hash/hash.h (+2/-0)
src/zorbaserialization/serialize_zorba_types.cpp (+2/-2)
src/zorbatypes/CMakeLists.txt (+2/-1)
src/zorbatypes/datetime/CMakeLists.txt (+3/-3)
src/zorbatypes/datetime/datetimetype.cpp (+37/-36)
src/zorbatypes/datetime/duration.cpp (+3/-4)
src/zorbatypes/timezone.cpp (+150/-180)
src/zorbatypes/timezone.h (+187/-59)
test/api/itemfactory.cpp (+2/-2)
Changed in zorba: | |
assignee: | Matthias Brantner (matthias-brantner) → Paul J. Lucas (paul-lucas) |
tags: | added: dates |
tags: | added: incompatible-change |
Changed in zorba: | |
status: | New → Fix Committed |
To post a comment you must log in.
The timezone units are also wrong in include/ zorba/item_ factory. h.