ZopeVersion asumes svn uses english locale

Reported by Lorenzo Gil Sanchez on 2007-12-20
2
Affects Status Importance Assigned to Milestone
Zope 3
Undecided
Lorenzo Gil Sanchez

Bug Description

The _getSVNInfoOutput helper method of zope.app.applicationcontrol.zopeversion.ZopeVersion class asumes that the locale the svn command is using is english. This class will parse the output of this command to get the current development version of Zope.

These are the offending lines:

        revision = info.get("Revision", "")
        url = info.get("URL", "")

I propose calling the svn command with a custom environment so the locale is always the C locale.

Lorenzo Gil Sanchez (lgs) wrote :

By the way, I don't know how to write a test for this bug without requiring subversion to be installed on the machine running the tests. And I don't know if this is such a good idea.

Changed in zope3:
assignee: nobody → lgs
status: New → In Progress
Lorenzo Gil Sanchez (lgs) wrote :

Fixed in revision 85956.

Changed in zope3:
status: In Progress → Fix Committed
Wolfgang Schnerring (wosc) wrote :

has long been released

Changed in zope3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers