MailHost has wrong strategy creating queue processing threads

Bug #574286 reported by Maric Michaud on 2010-05-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zope 2
Undecided
Tres Seaver

Bug Description

I was surprised by the behavior of asynchronous mailing in zope 2.11.3
MailHost product. It creates a thread by instance of MailHost by the
mean of using self.absolute_url(1) as key for the queue_threads dictionnary.

It seems obviously wrong, IMO, if several instances share the same queue directory,
mesages actually get sent more than once.

Following is a patch which works fine, but the idea is
straightforward, it's to use the realpath of the smtp_queue_directory as
the identifier of the thread, ensuring that MailHosts that share the
same queue directory will also share the same thread for processing mails.

This bug apply to zope 2.12 too, but the provided patch should work the same way.

Maric Michaud (maric) wrote :
Tres Seaver (tseaver) wrote :
Changed in zope2:
assignee: nobody → Tres Seaver (tseaver)
status: New → Fix Committed
Tres Seaver (tseaver) on 2010-05-13
Changed in zope2:
milestone: none → 2.12.5
Changed in zope2:
milestone: 2.12.5 → 2.12.6
Tres Seaver (tseaver) on 2010-05-18
Changed in zope2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers