_getContextName in Products.Five.browser.absoluteurl doesn't always return value

Bug #537453 reported by sagblmi
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Zope 2
Fix Released
Undecided
Martijn Pieters

Bug Description

Zope2-2.12.3

In Products.Five.browser.absoluteurl the _getContextName(self, context) is not completed

Current implementation:

 def _getContextName(self, context):
        if getattr(context, 'getId', None) is not None:
            return context.getId()
        getattr(context, '__name__', None)

expected implementation;
 def _getContextName(self, context):
        if getattr(context, 'getId', None) is not None:
            return context.getId()
        return getattr(context, '__name__', None)

Revision history for this message
Tres Seaver (tseaver) wrote :

MJ has checked in a fix for this bug, but still owes us a test.

Changed in zope2:
status: New → Fix Committed
Revision history for this message
Tres Seaver (tseaver) wrote :
Changed in zope2:
assignee: nobody → Martijn Pieters (mjpieters)
Revision history for this message
Hanno Schlichting (hannosch) wrote :

I'll let this slip through without a test.

Changed in zope2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.