reStructuredText package makes it impossible to override settings

Bug #143852 reported by strank
2
Affects Status Importance Assigned to Milestone
Zope 2
Invalid
Low
Unassigned

Bug Description

The reStructuredText package in Zope is overzealous to impose its settings dict on rendering docutils-restructuredtext.
Attached is a patch that honours all of the settings dict passed in by users.

Instead of copying the settings dict first, it uses it to update a new dict, after adding overridable settings and before adding settings based on the keyword parameters.

Revision history for this message
strank (strank) wrote :
Revision history for this message
Andreas Jung (ajung) wrote :

There is no patch

Changed in zope2:
status: New → Incomplete
Revision history for this message
strank (strank) wrote :

Yes there is. Launchpad, however, does not want you to find it... Click on 'View original description' and you will get the link: http://launchpadlibrarian.net/9460752/zoperest-honourusersettings.patch
cheers

Changed in zope2:
status: Incomplete → New
Revision history for this message
Simon Michael (simon) wrote :

+1 for applying this patch.

Revision history for this message
Tres Seaver (tseaver) wrote :

The patch needs a review to ensure that the re-ordering doesn't allow for unexpected
propagation of Zope-unsafe options, e.g.: file inclusion.

It should also include tests.

Changed in zope2:
importance: Medium → Low
status: New → Triaged
Revision history for this message
Colin Watson (cjwatson) wrote :

The zope2 project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope2.

Changed in zope2:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.