Two Unauthorized exceptions, why?

[Jens Vagelpohl]

There are two exception classes called Unauthorized defined in Zope: zExceptions.Unauthorized and AccessControl.Unauthorized. The version in AccessControl subclasses from the zExceptions code and overrides one method (getValueName), whereby both implementations attempt to do the same thing slightly differently.

The problem is that both classes are used in Zope without any rhyme or reason, and if you have an except clause you cannot catch zExceptions.Unauthorized by looking for AccessControl.Unauthorized, leading to much head-scratching.

I don't know what the rationale is to override getValueName in AccessControl.Unauthorized (the overridden implementation seems better than the one in zExceptions.Unauthorized), but it seems that AccessControl/unauthorized.py should go away and AccessControl/__init__.py should merely import zExceptions.Unauthorized for backwards compatibility.

[Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount)]

The standard workaround is to always look for zExceptions.Unauthorized in except clauses.