accidental acquisition
Bug #143403 reported by
Victor Safronovich
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zope 2 |
Fix Released
|
Low
|
Unassigned |
Bug Description
AccessControl.
Changed in zope2: | |
milestone: | none → 2.12.8 |
Changed in zope2: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch looks reasonable. It needs a test.
BTW, defining 'objectValues' (and 'objectIds' / 'objectItems') as
returning empty sequences for a leaf object is not a "dirty hack": it
is a classic application of the "composite pattern"[1]. Having leaves
share the abstract container interface makes writing recursive code
vastly simpler. I strongly doubt that this is the only place in the
Zope2 codebase which interacts badly with sub-objects which do not define
those methods.
[1] http:// en.wikipedia. org/wiki/ Composite_ pattern