Layer tearDown isn't called when running more processes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zope.testing |
Fix Released
|
Medium
|
Sidnei da Silva | ||
zope.testrunner |
Fix Released
|
Medium
|
Sidnei da Silva |
Bug Description
When running some tests with '-j2' I noticed that the tearDown of some layers are not run. I particularly noticed this one because the layer setUp starts a subprocess and tearDown should kill it, so it doesn't get killed.
Looking at the source of zope.testing (3.8.7), I see this:
if self.options.
if should_resume:
if layers_to_run:
if setup_layers:
if self.options.
If I remove the line that has 'setup_layers = None' then the layer tearDown gets called properly.
Related branches
- Sidnei da Silva: Approve
-
Diff: 147 lines (+40/-15)4 files modifiedCHANGES.txt (+5/-5)
src/zope/testrunner/runner.py (+11/-10)
src/zope/testrunner/testrunner-layers-buff.txt (+3/-0)
src/zope/testrunner/testrunner-layers.txt (+21/-0)
- Sidnei da Silva: Approve
-
Diff: 132 lines (+38/-10)4 files modifiedCHANGES.txt (+3/-0)
src/zope/testing/testrunner/runner.py (+11/-10)
src/zope/testing/testrunner/testrunner-layers-buff.txt (+3/-0)
src/zope/testing/testrunner/testrunner-layers.txt (+21/-0)
Changed in zope.testing: | |
importance: | Undecided → Medium |
Changed in zope.testrunner: | |
importance: | Undecided → Medium |
Changed in zope.testing: | |
assignee: | nobody → Sidnei da Silva (sidnei) |
Changed in zope.testrunner: | |
assignee: | nobody → Sidnei da Silva (sidnei) |
description: | updated |
Changed in zope.testing: | |
status: | New → Fix Committed |
Changed in zope.testrunner: | |
status: | New → Fix Committed |
http:// pypi.python. org/pypi/ zope.testing/ 3.9.5