Testrunner calls setUp/tearDown of super class when layers do not define setUp/tearDown themselves

[Christian Zagrodnick]

When layers are stacked a setUp may be called multiple times:

class LayerA(object):
    @classmethod
    def setUp(cls):
        print "foo'

class LayerB(LayerA):
    pass

A test using LayerB will print "foo" twice.

[Tres Seaver (tseaver)]

Layers which don't define setUp and tearDown are kind of beside the point.

[Jonathan Lange (jml)]

Note also:

class LayerA(object):
    def setUp(self):
        print "foo"

class LayerB(LayerA):
    def setUp(self):
        print "bar"

A test using LayerB will print "foo" then "bar". This is:
  1. Completely unlike practically any other Python code
  2. Apparently a deliberate decision made by zope.testing.

Although I don't like this behaviour, I think there's a compelling case for this bug being marked Wontfix – it's just how layers work.

Tres, we frequently define layers that don't define setUp and tearDown in order to have a test use more than one layer.

[Christian Zagrodnick (zagy)]

On 25.08.2010, at 17:48, Jonathan Lange wrote:

> Note also:
>
> class LayerA(object):
> def setUp(self):
> print "foo"
>
> class LayerB(LayerA):
> def setUp(self):
> print "bar"
>
> A test using LayerB will print "foo" then "bar". This is:
> 1. Completely unlike practically any other Python code
> 2. Apparently a deliberate decision made by zope.testing.

Sure. That's fine with me and I like that.

>
> Although I don't like this behaviour, I think there's a compelling case
> for this bug being marked Wontfix – it's just how layers work.
>
> Tres, we frequently define layers that don't define setUp and tearDown
> in order to have a test use more than one layer.

Actually testSetUp and testTearDown are also affected by this bug. If one layer A should define testSetUp all layers inherited from A need to define testSetUp to avoid superfluous calls to testSetUp.

--
Christian Zagrodnick · <email address hidden>
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel [phone] · fax [phone]
Zope and Plone consulting and development

[Colin Watson (cjwatson)]

The zope.testing project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope.testing.

[Colin Watson (cjwatson)]

The zope.testrunner project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope.testrunner.