Missing try/except to save PAS from faulty IRoles Plugins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zope PAS |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In PluggableAuthSe
try:
...
SomePlugin
...
except _SWALLOWABLE_
logger.debug( 'SomePlugin %s error' % ...)
However, this is not true for the IRoles plugin::
rolemakers = plugins.
for rolemaker_id, rolemaker in rolemakers:
roles = rolemaker.
if roles:
This has bitten us last week, when a faulty (and ironically not yet
needed) IRolesPlugin was the reason for a complete service loss for
half an hour.
So, is there a specific reason for the absence of the try/except?
In case it is not, i have made a patch and a (very amateurish) test case
against current PAS trunk
http://
Thanks,
Willi Langenberger
Changed in zope-pas: | |
status: | Fix Committed → Fix Released |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
status confirmed
assigned tseaver
Thanks very for the patch with tests -- I will check it in tomorrow, if enigmail. mozdev. org
all goes well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkx h+0AACgkQ+ gerLs4ltQ70GwCf XWs0FlVjENZkF05 k85qoSnBj narbEYe0lomsSiH 2B
MYsAnRWUa0pkQ1o
=/uGt
-----END PGP SIGNATURE-----