Zope Content Management Framework (CMF)

GenericSetup ignores new steps in dependencies chain

Reported by Ricardo Alves on 2008-04-08
2
Affects Status Importance Assigned to Milestone
Zope CMF
Medium
Wichert Akkerman

Bug Description

When running steps from profiles that include dependencies, the *new* steps (e.g. a new importVarious step defined in import_steps.xml) included by the profiles on the chain are ignored, with the exception of the first profile ran. AFIAK, this is happening because the list of steps from the first profile on the chain is never refreshed. I made a change that seems to fix this (attached).

Ricardo Alves (igbun) wrote :
Wichert Akkerman (wichert) wrote :

I can highly recommend to use zcml step registration instead - that will not suffer from this problem.

If you can add a test for this change I'll happily merge it.

Changed in zope-cmf:
assignee: nobody → wichert
importance: Undecided → Medium
status: New → Triaged
Ricardo Alves (igbun) wrote :

OK. I agree, zcml registration is cleaner.

Anyway, here is a patch with a test. It works for me (at least, all tests pass).

Wichert Akkerman (wichert) wrote :

I fixed one problem in the patch: explicit lists of steps to import that are passed in to _runImportStepsFromContext are not ignored.

I've commited the change to both trunk and the 1.4 branch.

Changed in zope-cmf:
status: Triaged → Fix Committed
Wichert Akkerman (wichert) wrote :

This was included in GenericSetup 1.4.1

Wichert Akkerman (wichert) wrote :

This was included in GenericSetup 1.1

Changed in zope-cmf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers