src/BTrees/BucketTemplate.c bug

[Jerry James]

I maintain the ZODB package in Fedora. A bug was filed recently showing the results of a static analysis of the ZODB 3.10.5 code. See https://bugzilla.redhat.com/show_bug.cgi?id=809284 for the full bug report and http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-04-02/python-ZODB3-3.10.5-2.fc17/ for the output from the static checker.

Contrary to what is said in the Fedora bug report, it appears to me that the Py_DECREF(r) on line 1745 of src/BTrees/BucketTemplate.c is wrong and should be removed. I'm not familiar enough with the ZOBD code to judge whether the other reports are really bugs or not.