please unify ZODB scripts

Reported by Toni Mueller on 2011-04-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ZODB
Undecided
Unassigned

Bug Description

Eg. 'analyze.py':

$ diff -uw analyze.py.old analyze.py
--- analyze.py.old 2010-12-26 18:43:56.000000000 +0100
+++ analyze.py 2011-04-20 19:52:09.000000000 +0200
@@ -138,6 +138,11 @@
     except Exception, err:
         print err

-if __name__ == "__main__":
+
+def main():
     path = sys.argv[1]
     report(analyze(path))
+
+if __name__ == "__main__":
+ main()
+

This should make it easier to call the scripts from anywhere (eg. generate wrappers around them via zc.buildout).

description: updated
Jim Fulton (jim-zope) wrote :

This would get applied a lot faster if there was a test.

Jim Fulton (jim-zope) wrote :

BTW, the main function should look more liike:

def main(args=None):
    if args is None:
        args = sys.argv[1:]
    [path] = args
    report(analyze(path))

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers