Feature for repozo: when making full backup, clean up all old backups.

Bug #143158 reported by Chris McDonough
4
Affects Status Importance Assigned to Milestone
ZODB
Fix Released
Medium
Jim Fulton

Bug Description

The attached patch to the current repozo.py in Zope 2.7 branch provides an additional command line option:

    -k / --kill-old-on-full
        If a full backup is created, remove any prior
        full or incremental backup files (and
        associated metadata files) from the
        repository directory.

This change is to make repozo "clean up after itself" as it creates backups through time (without the feature, a repository directory grows without bound).

Revision history for this message
Chris McDonough (chrism-plope) wrote :
Revision history for this message
Andreas Jung (ajung) wrote :

Please put it into the CVS. You have CVS access :-)

Revision history for this message
Chris McDonough (chrism-plope) wrote :

I don't change things in CVS/SVN that relate to ZODB, mostly because I don't know where I would need to replicate the checkin across all the places it lives.

Revision history for this message
Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount) wrote :

Suggestion: Make the switch accept a number describing the number of "generations" to keep. No one just keeps a single generation of backups around...

Revision history for this message
Chris McDonough (chrism-plope) wrote :

Fine by me, although it works pretty well for me now (I have a file backup routine that is generational, so this doesn't need to be).

Revision history for this message
Eddie Butcher (ebutcher) wrote :

What would be most useful is the ability to specify the number of backup files *kept*.

Revision history for this message
Chris McDonough (chrism-plope) wrote :

Yup, heard that the first time around <wink>. Again, most regular folks have backup systems that are already generational. Is anyone willing to try the patch to see if it meets their needs before engineering this thing into oblivion? ;-)

Revision history for this message
Tres Seaver (tseaver) wrote :

I have checked in this patch, with tests, on the following branch:

 http://svn.zope.org/ZODB/branches/tseaver-lp143158-feature/?rev=106808&view=rev

Please review and merge.

Changed in zope2:
status: New → In Progress
assignee: nobody → Jim Fulton (jim-zope)
affects: zope2 → zodb
Revision history for this message
Tres Seaver (tseaver) wrote :

Merged to trunk for the 3.10.0a2 release:

  http://svn.zope.org/ZODB/trunk/?rev=110913&view=rev

Changed in zodb:
status: In Progress → Fix Committed
Revision history for this message
Tres Seaver (tseaver) wrote :
Changed in zodb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers