zimdicator.py : glib.GError: Reached stack-limit of 50

Bug #584853 reported by Martin Wimpress 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zimdicator
Fix Released
Critical
Mitja Pagon

Bug Description

Hi,

Well, the move the XML is good certainly as I am getting notifications about new emails now.

However, this has exposed a new issue, since I have a lot on unread e-mail on a Monday morning ;-) If I run zimdicator.py from the shell, it produces this glib error.

Traceback (most recent call last):
  File "./zimdicator.py", line 209, in <module>
    zim = Zimdicator()
  File "./zimdicator.py", line 113, in __init__
    self.check_mail()
  File "./zimdicator.py", line 162, in check_mail
    n.show()
glib.GError: Reached stack-limit of 50

Regards, Martin.

Revision history for this message
Mitja Pagon (sect2k) wrote :

Hmm, googling for "glib stack-limit" doesn't produce any valuable results. I added a check to prevent multiple mail checks to run at once (since that might be the cause of stack overflow), other than that, I don't have any ideas at this time.

Also included in latest trunk is i18n support, i hope that it doesn't cause any additional issues.

Check it out and let me know how it goes.

Cheers,
M

Changed in zimdicator:
status: New → Fix Committed
assignee: nobody → Mitja Pagon (sect2k)
importance: Undecided → Critical
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Hi,

Just pulled in revision 9. Sadly, I still see the glib error. Here is the updated traceback when running from the shell.

Traceback (most recent call last):
  File "./zimdicator.py", line 232, in <module>
    zim = Zimdicator()
  File "./zimdicator.py", line 129, in __init__
    self.run_check_mail()
  File "./zimdicator.py", line 201, in run_check_mail
    return self.check_mail()
  File "./zimdicator.py", line 179, in check_mail
    n.show()
glib.GError: Reached stack-limit of 50

However, after the glib error, the notifications continue to display so they must have been queued already. Does n.show() raise an exception? If so you could try catching it. I've not got the time to look into it myself today :-(

Regards, Martin.

Revision history for this message
Mitja Pagon (sect2k) wrote :

I guess I didn't pay enough attention on the original traceback, and missed the part about n.show() raising exception, stupid me ;)
On the bright side, at least I now know how to tackle the problem. Thanks, your input has once more proven to be invaluable.

I'll just catch the exception for now, to see if other things work OK.

Cheers,
M

Revision history for this message
Mitja Pagon (sect2k) wrote :

I've limited display of new mail notifications to last 5 received and added a summary notification if there are more than five. Besides resolving the above issue I also believe its better from usability perspective (displaying large numbers of notifications is slow and distracting)

Anyhow, i18n support is working now, so if there are no show stopper bugs I'll release 0.2 tomorrow.

Beyond 0.2, i have some features in mind (folder subscriptions, better error handling) and if you would like to contribute, maybe it's best if we setup a battle plan, so we have some common goals to work towards.

Let me know how latest trunk works for you, as I would like to get 0.2 out ASAP, as 0.1 is unusable.

Cheers,
M

Mitja Pagon (sect2k)
Changed in zimdicator:
milestone: none → 0.2
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Hi Mitja,

Just checked out the current trunk. It's working very well, no issues encountered thus far. I think its good for a 0.2 release :-)

I'll certainly be a keen user of zimdicator and if I encounter any issues I'll be sure to report them and help where possible. I may send you some suggestions in the future. As for active development, probably not, I don't really have the time :-(

Thanks for improving zimdicator. I look forward to how zimdicator evolves and wish luck with that.

Until next time...

Regards, Martin.

Revision history for this message
Mitja Pagon (sect2k) wrote :

Hi Martin,

great to hear it's finally working. I'll make a 0.2 release, tonight if time permits or tomorrow otherwise.
Thanks for all your contributions, they were instrumental in getting this release out the door. More input is of course always welcome.

Until next time ...

Cheers,
M

Mitja Pagon (sect2k)
Changed in zimdicator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.