Tag is not indexed if not recognized by on-the-fly reformatting

Reported by Jiří Janoušek on 2011-06-02
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Zim
Low
Unassigned

Bug Description

Zim trunk, r404.

Steps to reproduce:
1) On the new line type "foo bar @baz" (no another space/Enter)
2) Tag is not recognized by on-the-fly reformatting (it's proper behavior)
3) Save page (or wait for autosave feature)
4) Tag is not indexed (not shown in tag cloud).
5) Reload the page
6) Tag was recognized by parser (brown color), but it isn't still indexed.
7) Modify the page and save.
8) The tag is finally indexed.

Expected behavior:
Tag should be indexed already in the step 4 (or in the step 6 at the latest).

The Cause:
The indexing code seems to use TextBuffer.get_parsetree() for tag indexing, but it may contain unrecognized tags.

Quick Fix:
Convert TextBuffer.get_parsetree() to the wiki format and then back to Parsetree to be sure all tags will be recognized and index this new Parsetree.

Jiří Janoušek (fenryxo) wrote :
Jiří Janoušek (fenryxo) wrote :

See also bug #793312 for a similar issue with same root cause

Changed in zim:
status: New → Confirmed
importance: Undecided → Low

Will commit fix rev432 -- put fix one level deeper in buffer.get_parsetree() and removed couple of places where this was hacked in already

Changed in zim:
status: Confirmed → Fix Committed

Removed this fix again from rev432 due to a regression in testing. Will re-apply the fix in a separate patch.

Changed in zim:
status: Fix Committed → In Progress
Sparhawk (sparhawkthesecond) wrote :

Thanks for the workaround (remodification + saving again). I use tags to track "todo" pages, and only just realised that most of these were missing from the tag cloud, and couldn't be found from the search dialogue.

(Is there a possibility to apply the fix, or is there still a regression?)

vanadium (ftack) wrote :

This bug may also be the cause that tagged "to do" items do not always appearing under their tag in the task list. This causes the listing of tasks per tag to be highly unreliable: tasks labeled sometimes appear, sometimes not. For this reason, I think this issue should be given more importance as it cripples the functionality of the task plugin.

vanadium (ftack) wrote :

I should have added that this concerns Zim 0.60 which now is included in the Ubuntu 13.10 repository. The issue was not there in the previous Zim edition coming with 13.04.

Sparhawk (sparhawkthesecond) wrote :

I'd definitely like to see the priority bumped on this. For my usage, it's almost equivalent to loss of data, as it's not obvious that I've lost the index's reference to tags.

This is now working correctly in the latest dev snapshot.

Changed in zim:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments