NoChangesError is thrown for various bzr errors

Reported by Cody A.W. Somerville on 2011-02-11
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Zim
High
Unassigned

Bug Description

When saving a new version and the notebook's bzr branch is binded and out of date with the master branch, NoChangesError is thrown. Zim only checks to see if the error code is 3 to determine if it should throw this error or not which is incorrect as 3 is used to indicate many different failures. The end result is that your changes don't get saved and Zim telling you incorrectly that there are no new changes to save.

Changed in zim:
status: New → Confirmed
importance: Undecided → High

From duplicate: this also happens e.g. when "whoami" is not set etc.

summary: - NoChangesError is thrown if binded bzr branch is out of date when saving
- new version
+ NoChangesError is thrown for various bzr errors

From duplicate: for fresh install the version command fails due to "whoami" not set in bazaar. Probably zim should check this and prompt the user for this.

Fixed usage of return code, now we just check "bzr st" to determine if we need to do a commit or not.

Will commit in rev399

Better check for setting "whoami" on first use still to be added - need to decide where to put interface code for this

Changed in zim:
status: Confirmed → In Progress

Note also that we do not get the STDERR of bzr in the error dialog, this also needs fixing.

Ignore that last comment - added stderr to the dialog, now getting at least the terminal output explaining why bzr fails in the dialog.

mtks (mtks) wrote :

Wow! Thanks! That seems to have fixed it. As I said, versions are new to me, so I figured that having installed bzr, I was set. (Perhaps the "whoami" settings could be included in the plug-in dialog where the autosave option is located. You could also add an adjustment for the frequency of autosaving.)

A few things (not sure if they are different bugs or related) pertaining to the "Versions" window:

(1) When "Page:XYZ" is selected w/ the radio button at the top, the "Side by Side" button at the bottom doesn't work seem to do anything.

(2) When using the "View Annotated" button, the name appended to changes is not the name used that I set with "whoami" but the first part of my email, i.e., X if the email address I gave is <email address hidden>

(3) Changing the radio button between "Whole Notebook" and "Page:XYZ" does not change the versions represented, e.g. I now have 10 versions, but if I create a new page, and select it with the radio selector, it appears as if there are 10 versions of that page, most of which are dated before the existence of the page.

Again, thanks!

Closing this report since the plugin code has been significantly changed since it was opened.

I believe there may still be a usability issue with bzr errors, but please open a new bug report if you encounter any.

Changed in zim:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers