Zim

Pages with sub pages cannot be moved via drag and drop

Bug #269090 reported by dotancohen
28
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Zim
Status tracked in Pyzim
Pyzim
Fix Released
Critical
Jaap Karssenberg

Bug Description

Pages that themselves have subpages cannot be moved to other places within the Index hierarchy via drag and drop. Furthermore, using the Rename function as a workaround to move the pages has these side effects:
1) The page is copied to the new location, not moved.
2) The page in the new location has no subpages. The subpages must be moved individually.

Tags: notebook
Revision history for this message
dotancohen (dotancohen) wrote :

Example:

The user has this hierarchy:

Page 1
-- Page 1.1
---- Page 1.1.1
---- Page 1.1.2

The user wants to move Page 1.1 to be a top-level page. By drag and drop this is impossible. However, if the user renames it from ":Page 1:Page 1.1" to "Page 1.1" then the final hierarchy looks like this:

Page 1
-- Page 1.1
---- Page 1.1.1
---- Page 1.1.2
Page 1.1

Instead, the hierarchy should look like this:
Page 1
Page 1.1
-- Page 1.1.1
-- Page 1.1.2

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Known issue, quite high on my list. But more difficult than it looks because of the requirement to keep links up to date. Will need to refactor some complicated logic there.

Changed in zim:
assignee: nobody → pardus-cpan
importance: Undecided → High
status: New → Triaged
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Demoting to "confirmed" because I want to reserve "triaged" for bugs that are ready to be patched immediately.

Changed in zim:
status: Triaged → Confirmed
Revision history for this message
dotancohen (dotancohen) wrote :

Sounds logical, I never did understand the technical difference between "confirmed" and "triaged" anyway.

Changed in zim:
assignee: pardus-cpan → nobody
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Moving of sub-trees is supported in the python branch now, so should work. Only drag & drop in the treeview is still broken in that branch :(

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Python branch now fully supports moving sub-trees by drag and drop. Check out revision 151 for testing.

Revision history for this message
Oliver Joos (oliver-joos) wrote :

I still see some problems when moving notes by drag and drop. I use zim 0.43 on Ubuntu 9.10. I have notes like:
  Bugs
  CodeBlocks
  Home
  Ubuntu
When I drag and drop the last note "Ubuntu" onto note "CodeBlocks" then an error dialog says:
  Invalid page name " -d "${FILE_PATH}" " - The given page name is not valid

The corresponding files and folders seem to change as expected but the sidepanel stays unchanged.
When I then "Re-build Index", the note "Ubuntu" disappears completely from the sidepanel. Restarting zim did not make it reappear. I tried this several times and also deleted folder ".zim/". But I had to move the file "Ubuntu.txt" out of folder "CodeBlocks/" manually and then restart zim to recover.

I also removed all zim-Links (like ":Ubuntu") from all pages - it is still reproducible.

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote : Re: [Bug 269090] Re: Pages with sub pages cannot be moved via drag and drop

@Oliver: I think this constitutes a new bug, so please open a new report for it.

Obvious question would be where the "-d "${FILE_PATH}" " is coming
from. Do you have a page by that name, or a link with that text or
something like that ?

Revision history for this message
Oliver Joos (oliver-joos) wrote :

You're right. I thought "-d "${FILE_PATH}" is some incomplete error message of zim. But it comes from one of my (quite big) imported texts! I found out that invalid links are the problem and opened new bug #520740

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.