Zim

Task list reload index doesn't work (807 revision)

Bug #1583152 reported by Pl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zim
Invalid
Undecided
Unassigned

Bug Description

Have tried the last development version of Zim and found a strange behavior in Task list plugin. It is introduced in 807 revision (in rev. 806 everything is OK).

How to reproduce: disable and then enable Task List plugin. Click on the corresponding button in the toolbar. The dialog 'Need to index the notebook' appears, wait until index is scanned, then this dialog disappears. After clicking on the button in the toolbar again the dialog will appear as if index wasn't scanned.

As I understand the reason is in 'reload_index' function in 'gui/__init__.py'. The program waits for a returned value to determine whether Cancel button was pressed in the dialog or not, but due to a presence of a decorator "@action(_('Update Index'), readonly=False)" it gets None type object.
The possible solution could be like in patch.

Revision history for this message
Pl (plprgt) wrote :
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

This issue is gone as we do the update now after enabling the dialog in preferences (that is flawed as well, but will fix differently)

Not returning from actions is on purpose - an "action" should be stateless and not return state back

Changed in zim:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.