Integrate search in the side pane

Reported by markba on 2007-08-25
80
This bug affects 14 people
Affects Status Importance Assigned to Milestone
Zim
Wishlist
Unassigned
zim (Ubuntu)
Wishlist
Unassigned

Bug Description

To make search feature more prominent, we should integrate it in the side pane, this is were users will expect to see it.

----
Original summary: zim: emphasize 'Search (in notes)'
Original desription:

Binary package hint: zim

Search in notes is possible through a shortcut (Ctrl-Shift-F) or by menu, but is much too important to stay 'hidden'.

For emphasizing this function, consider the following:
- icon on the main screen
- or .... search box above side pane (search-as-you-type)

Also, number of hits (= number of occurrences in note) can give an indication of releveance. Number of hits can be mentioned in parenthesis after the note name.

markba (mark-baaijens) wrote :

Gusty, zim 0.19

Changed in zim:
importance: Undecided → Wishlist
status: New → Confirmed

Thank you for your bug report. I'll add a Zim bug task.

description: updated
Changed in zim:
status: Confirmed → Triaged

There are some ideas on how to put more into the side pane, not decided yet.

In the dialog the "rank" corresponds to the number of hits. But it weighs the hits, e.g. a hit in the page name gives more points than a hit in the body.

Changed in zim:
importance: Undecided → Wishlist
status: New → Confirmed
description: updated
Peter Žagar (peter-zagar) wrote :

Just contributing my question from Answers section:
-----
Hello,

As someone who's migrating to Zim, I started to miss a killer feature of Tomboy.
Instant Search from toolbar. I think this is one of the greatest features of Tomboy.

For starters, I think it would be sufficient to just try adding Zim's search to the toolbar, without rewriting and redesigning much code.

Thanks and keep up the good work!
-----

tags: added: search sidepane ui usability
removed: gui

Code below can be added in "zim/gui/__init__.py" just below the call "self.uimanager.ensure_update()" (around line 540) and will add a search entry in the toolbar. In my mind this removes the need for adding search to the side pane, but open to suggestions.

  ###
  space = gtk.SeparatorToolItem()
  space.set_draw(False)
  space.set_expand(True)
  self.mainwindow.toolbar.insert(space, -1)

  def inline_search(entry, *a):
   text = entry.get_text()
   if text:
    self.show_search(text)

  from zim.gui.widgets import InputEntry
  entry = InputEntry()
  if gtk.gtk_version >= (2, 16):
   entry.set_icon_from_stock(gtk.ENTRY_ICON_SECONDARY, gtk.STOCK_FIND)
   entry.set_icon_activatable(gtk.ENTRY_ICON_SECONDARY, True)
   entry.set_icon_tooltip_text(gtk.ENTRY_ICON_SECONDARY, _('Search Pages...'))
  # FIXME would be nice to have function to set "Search" as grey background
  #entry.set_icon_to_clear()
  entry.connect('activate', inline_search)
  entry.connect('icon-release', inline_search)
  entry.show()
  item = gtk.ToolItem()
  item.add(entry)
  self.mainwindow.toolbar.insert(item, -1)
  ###

Changed in zim:
status: Confirmed → In Progress

Jaap, forgive me if I misunderstand, but does this only add an inline
search for the current page, or does it search across all pages? I
think the latter is what we are hoping to have in a side pane.

On Mon, Feb 18, 2013 at 9:47 AM, Jaap Karssenberg
<email address hidden> wrote:
> Code below can be added in "zim/gui/__init__.py" just below the call
> "self.uimanager.ensure_update()" (around line 540) and will add a search
> entry in the toolbar. In my mind this removes the need for adding search
> to the side pane, but open to suggestions.
>
>
> ###
> space = gtk.SeparatorToolItem()
> space.set_draw(False)
> space.set_expand(True)
> self.mainwindow.toolbar.insert(space, -1)
>
> def inline_search(entry, *a):
> text = entry.get_text()
> if text:
> self.show_search(text)
>
> from zim.gui.widgets import InputEntry
> entry = InputEntry()
> if gtk.gtk_version >= (2, 16):
> entry.set_icon_from_stock(gtk.ENTRY_ICON_SECONDARY, gtk.STOCK_FIND)
> entry.set_icon_activatable(gtk.ENTRY_ICON_SECONDARY, True)
> entry.set_icon_tooltip_text(gtk.ENTRY_ICON_SECONDARY, _('Search Pages...'))
> # FIXME would be nice to have function to set "Search" as grey background
> #entry.set_icon_to_clear()
> entry.connect('activate', inline_search)
> entry.connect('icon-release', inline_search)
> entry.show()
> item = gtk.ToolItem()
> item.add(entry)
> self.mainwindow.toolbar.insert(item, -1)
> ###
>
> ** Changed in: zim
> Status: Confirmed => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/134736
>
> Title:
> Integrate search in the side pane
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/zim/+bug/134736/+subscriptions

On Thu, Feb 21, 2013 at 2:00 AM, Adam Porter <email address hidden> wrote:
> Jaap, forgive me if I misunderstand, but does this only add an inline
> search for the current page, or does it search across all pages? I
> think the latter is what we are hoping to have in a side pane.

This will be "search" which means finding other pages. Searching
inside the current page is called "Find". (Don't hit me about it -
this is standard jargon from the interface guide.)

So this patch adds a search box in the upper right of the screen, what
seems to be the standard location now for many browsers and similar
application. Entering some text and hit <Enter> will pop up the search
dialog with results.

Regards,

Jaap

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers