Uncheck "update heading" option on rename when heading was changed

[Virgil Dupras]

When renaming a page, there's an option called "Update the heading of this page" which is checked by default. I think that this option doesn't make sense when the heading of the page has been manually changed. Many time, I've lost my heading changes by forgetting to uncheck this option.

I would suggest that before invoking the rename dialog, we verify whether the heading of the page is the same as the page title, and only check that box of it is.

zim 0.56 on Ubuntu 12.10

[Jaap Karssenberg (jaap.karssenberg)]

Good suggestion, I will look into it.

-- Jaap

On Sat, Nov 10, 2012 at 6:02 PM, Virgil Dupras <email address hidden> wrote:

> Public bug reported:
>
> When renaming a page, there's an option called "Update the heading of
> this page" which is checked by default. I think that this option doesn't
> make sense when the heading of the page has been manually changed. Many
> time, I've lost my heading changes by forgetting to uncheck this option.
>
> I would suggest that before invoking the rename dialog, we verify
> whether the heading of the page is the same as the page title, and only
> check that box of it is.
>
> zim 0.56 on Ubuntu 12.10
>
> ** Affects: zim
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to Zim.
> https://bugs.launchpad.net/bugs/1077400
>
> Title:
> Uncheck "update heading" option on rename when heading was changed
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/zim/+bug/1077400/+subscriptions
>

[Virgil Dupras (hsoft)]

For the fun of it, I've implemented the feature (with tests) and uploaded it on a personal branch. The commit is at http://bazaar.launchpad.net/~hsoft/zim/dev/revision/604

I'm quite unfamiliar with bzr and launchpad, please let me know if I did something wrong.

[Jaap Karssenberg (jaap.karssenberg)]

On Sun, Nov 11, 2012 at 9:31 PM, Virgil Dupras <email address hidden> wrote:

> For the fun of it, I've implemented the feature (with tests) and
> uploaded it on a personal branch. The commit is at
> http://bazaar.launchpad.net/~hsoft/zim/dev/revision/604
>

Patch looks good to me. Maybe I would rename "should_autochange_heading()"
to something like "heading_matches_pagename()". But that is a matter of
taste. Functionality wise this looks very robust, and happy to see test
cases included :)

> I'm quite unfamiliar with bzr and launchpad, please let me know if I did
> something wrong.
>

I can merge it from your branch as is. No further action needed.

To make it "formal" you could click the button "propose for merging" in the
branch overview at https://code.launchpad.net/~hsoft/zim/dev . That would
add your branch to an overview of branches that are ready, which serves to
remind me in case I forget to merge right away :)

Regards,

Jaap

[Jaap Karssenberg (jaap.karssenberg)]

Committed patch in rev 611

[Jaap Karssenberg (jaap.karssenberg)]

Released in zim 0.58