Datasource registry crashes Zeitgeist if template is invalid
Bug #903667 reported by
Seif Lotfy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
Low
|
Siegfried Gevatter | ||
Bug Description
If the template of a datasource registry extension is not corrent the datasource registry crashes when executing Event.from_variant. We should catch those and print out an error message while deleting the entry. This bug will also affect the blacklist extension.
Related branches
lp:~zeitgeist/zeitgeist/bluebird-sig-crash
- Michal Hruby (community): Needs Fixing
-
Diff: 224 lines (+63/-21)6 files modifiedextensions/blacklist.vala (+13/-3)
extensions/ds-registry.vala (+15/-2)
extensions/storage-monitor.vala (+14/-6)
src/datamodel.vala (+19/-9)
src/errors.vala (+1/-0)
src/sql.vala (+1/-1)
lp:~zeitgeist/zeitgeist/bluebird-sig-crash2
- Michal Hruby (community): Approve
-
Diff: 355 lines (+166/-63)4 files modifiedsrc/datamodel.vala (+22/-13)
src/errors.vala (+1/-0)
src/sql.vala (+1/-1)
test/direct/marshalling-test.vala (+142/-49)
| summary: |
- Datasource resigstry crashes Zeitgeist if template is invalid + Datasource registry crashes Zeitgeist if template is invalid |
| Changed in zeitgeist: | |
| milestone: | 0.9.1 → 0.9.0 |
Revision history for this message
| Siegfried Gevatter (rainct) wrote | #1 |
| Changed in zeitgeist: | |
| importance: | Medium → Low |
Revision history for this message
| Siegfried Gevatter (rainct) wrote | #2 |
| Changed in zeitgeist: | |
| assignee: | nobody → Siegfried Gevatter (rainct) |
| Changed in zeitgeist: | |
| status: | Confirmed → Fix Committed |
| Changed in zeitgeist: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Shouldn't be possible for this to happen, but yeah, it ought to be fixed for extra robustness.