Zeitgeist engine tells that an event has been inserted even though it has been blocked by an extension
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zeitgeist Framework |
Fix Released
|
Wishlist
|
Seif Lotfy |
Bug Description
I was working on blacklist when I noticed that even though the event insertion has been blocked by an extension, the engine still reports that the event has been inserted
Here is the output at the daemon
[2010-12-21 22:24:21,122] - ERROR - zeitgeist.engine - error while inserting 'Event(
Traceback (most recent call last):
File "/home/
return self._insert_
File "/home/
raise AssertionError(
AssertionError: Inserting of event was blocked by an extension
[2010-12-21 22:24:21,126] - DEBUG - zeitgeist.engine - Inserted 1 events in 0.001179s
The section in _zeitgeist/
http://
The AssertionError is raised on line 29 which is caught at line 11, but at line 3 and line 4, there is no way to check that the the event was actually inserted
I was recommend some way to track how many events have been inserted and how many have been blocked
Related branches
- Siegfried Gevatter: Approve
-
Diff: 15 lines (+3/-2)1 file modified_zeitgeist/engine/main.py (+3/-2)
Changed in zeitgeist: | |
assignee: | nobody → Seif Lotfy (seif) |
status: | New → Fix Committed |
status: | Fix Committed → In Progress |
milestone: | none → 0.7.0 |
Changed in zeitgeist: | |
status: | In Progress → Fix Committed |
importance: | Undecided → Wishlist |
Changed in zeitgeist: | |
status: | Fix Committed → Fix Released |
Yup. Or rename the message so it's clear the the query was inserting X
events but not all of them may have been successful (eg "Requested
insertion of X events" or "Processed X events").
This message is just there for the timing information and users aren't
supposed to care about it.