Hook before event deletions missing

Bug #604747 reported by Siegfried Gevatter on 2010-07-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Medium
Seif Lotfy

Bug Description

Now that there is a hook called after event deletions (with which I only agree because of performance reasons for the FTS extension, as it is basically duplicating the D-Bus interface), there should also be a hook called before events are deleted which can stop that from happening.

Related branches

Changed in zeitgeist:
milestone: none → 0.4.1
Markus Korn (thekorn) wrote :

Maybe we should take the chance and rethink the neaming scheme of hooks, so they better describe what they are doing, I propose sth. like:

 pre_insert_event
 post_delete_event
 pre_delete_event
 [...]

(I think we can also drop the _hook suffix)

2010/7/14 Markus Korn <email address hidden>:
> Maybe we should take the chance and rethink the neaming scheme of hooks,
> so they better describe what they are doing, I propose sth. like:

Agreed. I was thinking of something like insert_event_hook and
insert_event_notify_hook, this way we don't break any released API.

+1 for Markus' suggestion - but it'll break the Extension API - which isn't that big a deal I think... The next release is the first where the Extensions are dynamically loaded anyway.

Remember to update the in-tree extensions!

Siegfried Gevatter (rainct) wrote :

okidoky, +1

Seif Lotfy (seif) on 2010-07-30
Changed in zeitgeist:
assignee: nobody → Seif Lotfy (seif)
importance: Undecided → Medium
status: New → Triaged
Seif Lotfy (seif) on 2010-08-02
Changed in zeitgeist:
status: Triaged → Fix Released
Changed in zeitgeist:
milestone: 0.4.1 → 0.5.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers