Hook before event deletions missing

[Siegfried Gevatter]

Now that there is a hook called after event deletions (with which I only agree because of performance reasons for the FTS extension, as it is basically duplicating the D-Bus interface), there should also be a hook called before events are deleted which can stop that from happening.

[Markus Korn (thekorn)]

Maybe we should take the chance and rethink the neaming scheme of hooks, so they better describe what they are doing, I propose sth. like:

 pre_insert_event
 post_delete_event
 pre_delete_event
 [...]

(I think we can also drop the _hook suffix)

[Siegfried Gevatter (rainct)]

2010/7/14 Markus Korn <email address hidden>:
> Maybe we should take the chance and rethink the neaming scheme of hooks,
> so they better describe what they are doing, I propose sth. like:

Agreed. I was thinking of something like insert_event_hook and
insert_event_notify_hook, this way we don't break any released API.

[Mikkel Kamstrup Erlandsen (kamstrup)]

+1 for Markus' suggestion - but it'll break the Extension API - which isn't that big a deal I think... The next release is the first where the Extensions are dynamically loaded anyway.

Remember to update the in-tree extensions!

[Siegfried Gevatter (rainct)]

okidoky, +1