Hook before event deletions missing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
Medium
|
Seif Lotfy |
Bug Description
Now that there is a hook called after event deletions (with which I only agree because of performance reasons for the FTS extension, as it is basically duplicating the D-Bus interface), there should also be a hook called before events are deleted which can stop that from happening.
Related branches
- Siegfried Gevatter: Approve on 2010-08-02
- Seif Lotfy: Approve on 2010-08-02
-
Diff: 285 lines (+119/-31)5 files modified_zeitgeist/engine/extension.py (+61/-18)
_zeitgeist/engine/extensions/blacklist.py (+1/-1)
_zeitgeist/engine/extensions/datasource_registry.py (+1/-1)
_zeitgeist/engine/main.py (+6/-2)
test/engine-extension-test.py (+50/-9)
Changed in zeitgeist: | |
milestone: | none → 0.4.1 |
Markus Korn (thekorn) wrote : | #1 |
2010/7/14 Markus Korn <email address hidden>:
> Maybe we should take the chance and rethink the neaming scheme of hooks,
> so they better describe what they are doing, I propose sth. like:
Agreed. I was thinking of something like insert_event_hook and
insert_
+1 for Markus' suggestion - but it'll break the Extension API - which isn't that big a deal I think... The next release is the first where the Extensions are dynamically loaded anyway.
Remember to update the in-tree extensions!
Siegfried Gevatter (rainct) wrote : | #4 |
okidoky, +1
Changed in zeitgeist: | |
assignee: | nobody → Seif Lotfy (seif) |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in zeitgeist: | |
status: | Triaged → Fix Released |
Changed in zeitgeist: | |
milestone: | 0.4.1 → 0.5.0 |
Maybe we should take the chance and rethink the neaming scheme of hooks, so they better describe what they are doing, I propose sth. like:
pre_insert_event
post_delete_event
pre_delete_event
[...]
(I think we can also drop the _hook suffix)