Deletes are not committed

Bug #566184 reported by Mikkel Kamstrup Erlandsen on 2010-04-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Undecided
Mikkel Kamstrup Erlandsen

Bug Description

When we do engine.delete_events(ids) we never call commit() on the sqlite3 connection. This means that if the engine is shut down before we've committed because of other circumstances (eg. insert_events()) then the deleted items will reappear

Related branches

Fixed in r1415

Changed in zeitgeist:
status: New → Fix Committed
milestone: none → 0.3.3
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)

i now get
======================================================================
FAIL: testDeleteSingle (__main__.ZeitgeistEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/engine-test.py", line 127, in testDeleteSingle
    self.assertEquals(0, len(filter(None, result)))
AssertionError: 0 != 1

On Sun, Apr 18, 2010 at 9:56 PM, Mikkel Kamstrup Erlandsen <
<email address hidden>> wrote:

> Fixed in r1415
>
> --
> Deletes are not committed
> https://bugs.launchpad.net/bugs/566184
> You received this bug notification because you are subscribed to The
> Zeitgeist Project.
>
> Status in Zeitgeist Framework: Fix Committed
>
> Bug description:
> When we do engine.delete_events(ids) we never call commit() on the sqlite3
> connection. This means that if the engine is shut down before we've
> committed because of other circumstances (eg. insert_events()) then the
> deleted items will reappear
>
>
>
>

Thanks, I just uploaded a fix to your issue Seif. It was an odd corner case where we'd mistakingly assume that we didn't have any events for the given ids if all the deleted events had timestamp 0. This was because we used the builtin method all() to check the timestamps...

Changed in zeitgeist:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers