Failing remote-test and blacklist-test testcases

[Markus Korn]

As of today I get the following results:

======================================================================
ERROR: testApplyBlacklist (blacklist-test.BlacklistTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/devel/zeitgeist/trunk/test/blacklist-test.py", line 48, in testApplyBlacklist
    self.testSetOne()
  File "/media/devel/zeitgeist/trunk/test/blacklist-test.py", line 36, in testSetOne
    self.blacklist.SetBlacklist([orig])
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 68, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 610, in call_blocking
    message.append(signature=signature, *args)
TypeError: Expected a string or unicode object

======================================================================
ERROR: testClear (blacklist-test.BlacklistTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/devel/zeitgeist/trunk/test/blacklist-test.py", line 29, in testClear
    self.blacklist.SetBlacklist([])
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 68, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 610, in call_blocking
    message.append(signature=signature, *args)
ValueError: Unable to guess signature from an empty list

======================================================================
ERROR: testSetOne (blacklist-test.BlacklistTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/devel/zeitgeist/trunk/test/blacklist-test.py", line 36, in testSetOne
    self.blacklist.SetBlacklist([orig])
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 68, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 610, in call_blocking
    message.append(signature=signature, *args)
TypeError: Expected a string or unicode object

======================================================================
ERROR: testFindRelated (remote-test.ZeitgeistRemoteAPITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/devel/zeitgeist/trunk/test/remote-test.py", line 210, in testFindRelated
    TimeRange.always(), callback)
  File "/media/devel/zeitgeist/trunk/test/../zeitgeist/client.py", line 588, in find_related_uris_for_uris
    self.find_related_uris_for_events([event_template], *args, **kwargs)
  File "/media/devel/zeitgeist/trunk/test/../zeitgeist/client.py", line 577, in find_related_uris_for_events
    error_handler=self._safe_error_handler(error_handler))
  File "/usr/lib/pymodules/python2.6/dbus/proxies.py", line 132, in __call__
    **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 556, in call_async
    message.append(signature=signature, *args)
ValueError: Unable to guess signature from an empty list

----------------------------------------------------------------------
Ran 67 tests in 36.629s

FAILED (errors=4)

Not sure if this testcases ever worked, needs further investigation.
But obviously no blacklist testcases runs fine, so this is blocking any release.

[Mikkel Kamstrup Erlandsen (kamstrup)]

They used to work fine so some recent commit must have broken them

[Markus Korn (thekorn)]

Just tried to find the reasons for the failures,
 * The error in 'testFindRelated' also happens in lp:zeitgeist rev 1250 (which is before the blacklist merge)
 * the other (blacklist related) failures started right after the merge (rev 1251), but they work fine in lp:~kamstrup/zeitgeist/blacklist

[Markus Korn (thekorn)]

------------------------------------------------------------
revno: 1258
committer: Markus Korn <email address hidden>
branch nick: trunk
timestamp: Wed 2010-01-06 10:33:03 +0100
message:
  The blacklist is running in its own DBus scope (object_path and interface
  address). Using this instead of the generic zeitgeist addresses.
------------------------------------------------------------
revno: 1257
committer: Markus Korn <email address hidden>
branch nick: trunk
timestamp: Wed 2010-01-06 10:09:29 +0100
message:
  Fixed code to find related events. The API and engine methods got renamed
  some time ago, but not all neccessary bits where updated accordingly

These test failures a a classical example of doing string changes in our code without running the testsuite afterwards.
We have this testsuite, it's running fast so we should really run it *before* each of our commits to lp:zeitgeist. Fixing failures a week after the commit costs much more time and causes much more trouble than doing a couple of times around each commit.