Add origin as a property of events
Bug #425258 reported by
Siegfried Gevatter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zeitgeist Framework |
Fix Released
|
Undecided
|
Siegfried Gevatter |
Bug Description
Both http://
I'm filling this bug so that we don't remember to fix it, but please let's ignore it until we get the basic event/item separation stuff merged - most important stuff first.
Related branches
lp:~zeitgeist/zeitgeist/dbschema4
- Mikkel Kamstrup Erlandsen: Approve
-
Diff: 246 lines (+121/-28)3 files modified_zeitgeist/engine/main.py (+5/-2)
_zeitgeist/engine/sql.py (+41/-25)
_zeitgeist/engine/upgrades/core_3_4.py (+75/-1)
Changed in zeitgeist: | |
importance: | Undecided → Medium |
milestone: | none → 0.3 |
status: | New → Triaged |
Changed in zeitgeist: | |
milestone: | 0.3.0 → 0.8.0 |
importance: | Medium → Undecided |
summary: |
- origin should be a property of events, not items + Add origin as a property of events |
Changed in zeitgeist: | |
status: | New → In Progress |
Changed in zeitgeist: | |
status: | In Progress → Fix Committed |
assignee: | nobody → Siegfried Gevatter (rainct) |
Changed in zeitgeist: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Note that events should be regarded as sub types of items, meaning that an event is comprised of both the relevant row in the item table and the corresponding row in the event table. This means that events do in fact have origins.
I do agree, however, that an origin is a URL, and as such should be stored in the uri table. Meaning that item.origin should converted to an INTEGER and be renamed to item.origin_id.