Do not store application info in the DB

Bug #398440 reported by Siegfried Gevatter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Medium
Unassigned

Bug Description

""""""""""""""""""""""""""""""""""""""""""
# Insert the application
# FIXME: Is reading the .desktop file and storing that stuff into
# the DB really required?
app_info = DesktopEntry(ritem["app"])
app_uri_id, app_content_id, app_source_id = self._get_ids(ritem["app"],
 unicode(app_info.getType()), unicode(app_info.getExec()).split()[0])
app_item = self._get_item(app_uri_id, app_content_id, app_source_id,
 unicode(app_info.getName()), icon=unicode(app_info.getIcon()))
try:
 self.store.execute("INSERT INTO app (item_id, info) VALUES (?,?)",
  (app_uri_id, unicode(ritem["app"])), noresult=True)
except sqlite3.IntegrityError:
 pass
""""""""""""""""""""""""""""""""""""""""

Why are we inserting this into the DB (and making insertion slower by loading all the .desktop files, which should probably be workarounded with a cache in case we keep it) when we don't use it for anything, and this isn't contemplated in the Database spec?

(Additionally, in case we keep it we need to contemplate that Exec= may be empty, as else this results in a crash).

Related branches

Changed in zeitgeist:
status: New → In Progress
importance: Undecided → Medium
importance: Medium → Undecided
milestone: none → 0.2
status: In Progress → New
status: New → Confirmed
importance: Undecided → Medium
Changed in zeitgeist:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.