filters argument of ZeitgeistEngine.find_events() should be a list of dicts

Bug #392216 reported by Markus Korn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Medium
Markus Korn
[Legacy] GNOME Activity Journal
Fix Released
Undecided
Unassigned

Bug Description

currently the filters option of the find_events method takes takes a list of lists as argument. Whenever someone would like to use this option right now is is necessary to also give all defaults of one filter, if we change it to a list of dicts it would be much easier, as we can just ignore the defaults

Revision history for this message
Markus Korn (thekorn) wrote :

attached a branch for fixing this bug in lp:zeitgeist

Changed in zeitgeist:
assignee: nobody → Markus Korn (thekorn)
status: New → In Progress
Revision history for this message
Markus Korn (thekorn) wrote :

This patch uses the new API introduced by the branch above in lp:gnome-zeitgeist

Revision history for this message
Siegfried Gevatter (rainct) wrote :

«text_name = filter.get("text_name", None)
if text_name is not None:»

That's overkill, just «if "text_name" in filter:» and the «filter["text_name"]» is more than enough.

Looks good otherwise. Thanks for working on this.

Changed in zeitgeist:
milestone: none → 0.1
Changed in zeitgeist:
importance: Undecided → Medium
status: In Progress → Fix Released
Revision history for this message
Markus Korn (thekorn) wrote :

gnome-zeitgeist needs to be patched with the diff from comment #2

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Did that, but forgot to push it :).

Changed in gnome-zeitgeist:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers