Log: Loop not properly cleaned up on failures in Log constructor

[Albert Astals Cid]

If the lambda fails the code leaves a MainLoop around that breaks things (i.e. the Qt main glib loop).

Patches and stuff at https://bugs.freedesktop.org/show_bug.cgi?id=88846

[Albert Astals Cid (aacid)]

If the lambda fails the code leaves a MainLoop around that breaks things (i.e. the Qt main glib loop).

I'm attaching the patch that fixes the problem, the generated code with and the patch.

[Albert Astals Cid (aacid)]

Created attachment 112905
The patch

Add finally {} to try {} catch {}

[Albert Astals Cid (aacid)]

Created attachment 112906
Generated .c code if unpatched

Note that there's some return; error conditions where the loop is not exited correctly with g_main_loop_quit (_data1_->mainloop);

[Albert Astals Cid (aacid)]

Created attachment 112907
Generated .c code if patched

Note that all the exit paths properly have a g_main_loop_quit (_data1_->mainloop);

[Albert Astals Cid (aacid)]

Please if possible credit this to "Albert Astals Cid <email address hidden>" and not to "Albert Astals Cid <email address hidden>" I'm just using my kde.org account since I didn't feel like creating a new one just for this.

[Albert Astals Cid (aacid)]

Created attachment 112950
The patch

[Albert Astals Cid (aacid)]

It's been commited.