spaces in paths confuse the zopectl startup script

[Martijn Faassen]

Using zc.zope3recipes, if I place a Zope 3 buildout in a directory where one of the parents has a space in it, such as

/tmp/spaces in path/mybuildout

the zopectl script gets confused. On linux I get the following output:

/home/faassen/tmp/spaces in/store-071116/parts/app/runzope -C /home/faassen/tmp/spaces in/store-071116/parts/zopectl/zope.conf

i.e. as normal, but then nothing happens. The system returns to the next command prompt immediately.

On Windows, the following error occurs:

Error: positional arguments are not supported
For help, use C:\[elided]\runzope-script.py - h
Zope 3 started int he foreground: [elided]\runzope -C [elided]\parts\zopectl\zope.conf

It looks like some shell escaping isn't taking place where it should be?

[Christophe Combelles (ccomb)]

This happens also with the standard zope 3.3.1 distribution

[Christophe Combelles (ccomb)]

The problem is the following:

In the <runner> section, zdaemon.conf defines a 'program' parameter that looks like this:
/some/path/with spaces/runzope -C /some/path/with spaces/zope.conf

This line is splitted into 5 separate strings, and started by zdaemon/zdctl.py with:
os.spawnlp(os.P_WAIT, program[0], *program)
or
os.spawnvp(flag, args[0], args)

But args[0] is "/some/path/with" instead of "/some/path/with spaces/runzope"

There is no problem with other parameters such as 'directory' or 'transcript' because they are treated as single entities and are not tried to be splitted. The 'program' parameter is composed of 3 items but splitted in 5.