extends from a URL does not respect "newest = false"

[Rafael Monnerat]

The option "newest = false", has no effect when extends a URL is used, URLs are downloaded and extends are updated for every buildout run. Considering the followed buildout.cfg:

[buildout]
newest = false
extends =
  https://svn.erp5.org/repos/public/erp5/trunk/buildout/buildout-2.12.cfg
extends-cache = extends-cache

And the followed steps:

$ python bootstrap.py # All extends are downloaded into extends-cache folder.
$ bin/buildout # All extends are downloaded again into extends folder and use offline is not an option available.

The extends files should be not downloaded again during "bin/buildout" due "newest = false", and only new files should be downloaded.

I'm attaching proposal patch to fix this problem.

[Rafael Monnerat (rafael-nexedi)]

I'm attaching a patch.

In the patch, we provide to zc.buildout.download.Download, the appropriate fallback argument, which makes it avoid download again already downloaded files, present in extends-cache.

[Rafael Monnerat (rafael-nexedi)]

A patch with a test for this bug was added at:

 http://launchpadlibrarian.net/64413102/extends-cache_testForBugs717802And717730.patch