Failing tests under Python 3.6

Bug #1753997 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Undecided
wangxiyuan

Bug Description

Building Zaqar 6.0.0 under Debian Sid and Python 3.6 leads to the below unit test failures.

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_default_ttl_and_grace
zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_default_ttl_and_grace
----------------------------------------------------------------------
_StringException: pythonlogging:'zaqar': {{{Response: API v2 txt, 204. Request: action "queue_create", body {"queue_name": "skittle"}.}}}

Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_claims.py", line 50, in setUp
    self.assertEqual(201, resp['headers']['status'])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 201 != 204

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_exceeded_claim
zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_exceeded_claim
----------------------------------------------------------------------
_StringException: pythonlogging:'zaqar': {{{Response: API v2 txt, 204. Request: action "queue_create", body {"queue_name": "skittle"}.}}}

Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_claims.py", line 50, in setUp
    self.assertEqual(201, resp['headers']['status'])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 201 != 204

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_unacceptable_ttl_or_grace_1___1___1_
zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_unacceptable_ttl_or_grace_1___1___1_
----------------------------------------------------------------------
_StringException: pythonlogging:'zaqar': {{{Response: API v2 txt, 204. Request: action "queue_create", body {"queue_name": "skittle"}.}}}

Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_claims.py", line 50, in setUp
    self.assertEqual(201, resp['headers']['status'])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 201 != 204

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_unacceptable_ttl_or_grace_2__59__60_
zaqar.tests.unit.transport.websocket.v2.test_claims.ClaimsBaseTest.test_unacceptable_ttl_or_grace_2__59__60_
----------------------------------------------------------------------
_StringException: pythonlogging:'zaqar': {{{Response: API v2 txt, 204. Request: action "queue_create", body {"queue_name": "skittle"}.}}}

Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_claims.py", line 50, in setUp
    self.assertEqual(201, resp['headers']['status'])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 201 != 204

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_messages.MessagesBaseTest.test_unsupported_json_1___overflow___9223372036854775808_
zaqar.tests.unit.transport.websocket.v2.test_messages.MessagesBaseTest.test_unsupported_json_1___overflow___9223372036854775808_
----------------------------------------------------------------------
_StringException: pythonlogging:'zaqar': {{{Response: API v2 txt, 204. Request: action "queue_create", body {"queue_name": "kitkat"}.}}}

Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_messages.py", line 56, in setUp
    self.assertEqual(201, resp['headers']['status'])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 201 != 204

======================================================================
FAIL: zaqar.tests.unit.transport.websocket.v2.test_subscriptions.SubscriptionTest.test_subscription_create
zaqar.tests.unit.transport.websocket.v2.test_subscriptions.SubscriptionTest.test_subscription_create
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_subscriptions.py", line 55, in setUp
    self.protocol.onMessage(req, False)
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/transport/websocket/protocol.py", line 141, in onMessage
    return self._send_response(resp, isBinary)
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/transport/websocket/protocol.py", line 210, in _send_response
    self.sendMessage(json.dumps(resp.get_response()), False)
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1062, in __call__
    return _mock_self._mock_call(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1128, in _mock_call
    ret_val = effect(*args, **kwargs)
  File "/home/zigo/sources/openstack/queens/services/zaqar/build-area/zaqar-6.0.0/zaqar/tests/unit/transport/websocket/v2/test_subscriptions.py", line 51, in validator
    self.assertEqual(resp['headers']['status'], 201)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 204 != 201

Revision history for this message
wangxiyuan (wangxiyuan) wrote :
Changed in zaqar:
assignee: nobody → wangxiyuan (wangxiyuan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/550723
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=8e0dd9763aba67bb7094cf92312daeba8d087866
Submitter: Zuul
Branch: master

commit 8e0dd9763aba67bb7094cf92312daeba8d087866
Author: wangxiyuan <email address hidden>
Date: Thu Mar 8 14:55:36 2018 +0800

    Fix assert error during queue creating in ut

    In some concurrent test case, the queue may be created
    more than one time in the setup function. Since the queue
    in Zaqar is lazy, it returns 201 or 204 in this case.

    Change-Id: I1c8163a5cfb10071650b5ae16cc53d61503621a2
    Closes-bug: #1753997

Changed in zaqar:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zaqar 7.0.0.0b1

This issue was fixed in the openstack/zaqar 7.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.