Zaqar uses trollius inconditionnally

[Thomas Goirand]

Trollius is deprecated, and should not be used. Also, it's a Python 2 only thing, and zaqar has it in its requirements.txt as always on (ie: with Python 3 also). Please at least make it so that it wont be used if under Py3, and even better, remove it completely.

[wangxiyuan (wangxiyuan)]

trollius is introduced to zaqar for py2 backward compatibility.

https://github.com/openstack/zaqar/blob/master/zaqar/transport/websocket/driver.py#L22

We can't remove it until python2 is not supported any more.

But we can mark it should be only used under python2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/550710

[OpenStack Infra (hudson-openstack)]

Change abandoned by wangxiyuan (<email address hidden>) on branch: master
Review: https://review.openstack.org/550710
Reason: ops, should be fixed in openstack/requirements

[Tony Breeds (o-tony)]

Removing this from requirements will then break zaqar as it unconditionally imports it.

Also I don't see anything that indicates that trollius is deprecated. I agree it's a backport of asyncio to older pythons that don't have it but conceptually it isn't that different from say mock

[wangxiyuan (wangxiyuan)]

fixed in requirements repo

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements stein-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements xena-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/requirements zed-eom release.