pre-signed URL doesn't work with url like /v2/queues/myqueue/messages/xxx

Bug #1596769 reported by Feilong Wang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
wanghao

Bug Description

Now for zaqar presigned URL, user can only input paths like claims, messages, as a result, a URL like /v2/queues/myqueue/messages/xxx doesn't work. In other words, if we use pre signed zaqar client, the client can only post, get resources collection, and can't handle single resource.

Revision history for this message
Feilong Wang (flwang) wrote :

I would like to see flaper87's comments on this bug.

Changed in zaqar:
importance: Undecided → High
Feilong Wang (flwang)
Changed in zaqar:
assignee: nobody → Fei Long Wang (flwang)
Revision history for this message
Flavio Percoco (flaper87) wrote :

I believe it was a choice to not allow for accessing objects directly.

What's the use case driving this?

Revision history for this message
wanghao (wanghao749) wrote :

I prefer to support it in Zaqar, if user can get resources collection with presigned URL, why not they also can get single resource?

Revision history for this message
wanghao (wanghao749) wrote :
Changed in zaqar:
assignee: Fei Long Wang (flwang) → wanghao (wanghao749)
Changed in zaqar:
status: New → In Progress
Revision history for this message
Feilong Wang (flwang) wrote :

The user case came from the aodh zaqar driver. At that moment, user will get a 409 error when create a duplicated subscription, which will cause some unexpected errors at here https://github.com/openstack/aodh/blob/master/aodh/notifier/zaqar.py#L162

And when the zaqar driver was introduced at the first time, it doesn't support pre-signed URL. So that said, all the subscriptions have to be created in the driver, can't create in Zaqar. That's why I opened this bug.

But now, things changed. Firstly, Zaqar won't throw 409 if there is a duplicated subscription creation. And, Aodh's Zaqar driver can support pre-signed URL. So user can create subscriptions in Zaqar easily.

So, technically, we don't really have to support this now. But Flavio, would you mind explaining the design choice a bit more? Thanks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/401901
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=d3c1361f4e0521173d3ae1a614791bda5a810ce7
Submitter: Jenkins
Branch: master

commit d3c1361f4e0521173d3ae1a614791bda5a810ce7
Author: wanghao <email address hidden>
Date: Thu Nov 24 16:00:04 2016 +0800

    Support to query single resource with pre-signed url

    Now Zaqar only supports to post and get resources
    collection by using pre-signed url, this path
    add the ability to query single resource.

    Change-Id: I82b208e72a79319d9757754e34a688e86c6b0ff4
    Closes-Bug: #1596769

Changed in zaqar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zaqar 5.0.0.0b3

This issue was fixed in the openstack/zaqar 5.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.