DRY not being respected on zaqar/storage/utils.py

[Victoria Martinez de la Cruz]

The code merged to fix the py34 gate (avoiding _getattr_ reentring calls on py34) does not respect the DRY principle

    if dynamic:
        if not conf.safe_get(storage_group):
            conf.register_opts(storage_opts,
                               group=storage_group)
        if not conf.safe_get('drivers'):
            # NOTE(cpp-cabrera): parse general opts: 'drivers'
            driver_opts = utils.dict_to_conf({'message_store': storage_type})
            conf.register_opts(driver_opts, group=u'drivers')
    else:
        if storage_group not in conf:
            conf.register_opts(storage_opts,
                               group=storage_group)
        if 'drivers' not in conf:
            # NOTE(cpp-cabrera): parse general opts: 'drivers'
            driver_opts = utils.dict_to_conf({'message_store': storage_type})
            conf.register_opts(driver_opts, group=u'drivers')

We need to refactor this

[wanghao (wanghao749)]

Fix is here: https://review.openstack.org/#/c/320178/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320178
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=437c2fe5671881189aba55391720d1a5351e1839
Submitter: Jenkins
Branch: master

commit 437c2fe5671881189aba55391720d1a5351e1839
Author: wanghao <email address hidden>
Date: Tue May 24 09:35:49 2016 +0800

    Refactor zaqar/storage/utils.py to respect DRY

    Refactor the code merged to fix the py34 issue,
    let it follow the DRY principle.

    Depends-on: I6da301dc4935ec8e4254d71ca93036f3d8db2bcf
    Change-Id: Iaa0768e795e172649787dc6d26722848b5d732ee
    Closes-Bug: #1584958

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/zaqar 3.0.0.0b1 development milestone.