DRY not being respected on zaqar/storage/utils.py
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zaqar |
Fix Released
|
Low
|
wanghao |
Bug Description
The code merged to fix the py34 gate (avoiding _getattr_ reentring calls on py34) does not respect the DRY principle
if dynamic:
if not conf.safe_
if not conf.safe_
# NOTE(cpp-cabrera): parse general opts: 'drivers'
else:
if storage_group not in conf:
if 'drivers' not in conf:
# NOTE(cpp-cabrera): parse general opts: 'drivers'
We need to refactor this
Changed in zaqar: | |
importance: | Undecided → Low |
Fix is here: https:/ /review. openstack. org/#/c/ 320178/