Add Missing Unit Tests

Bug #1369536 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Medium
Flavio Percoco

Bug Description

Two tests are missing from our unit test suite to handle recent regression:

* DELETE messages with expired claim ID

The blueprint mentioned testing update of an expired claim which is already tested in the `test_expired_claim` test.

(there was a bp for this https://blueprints.launchpad.net/zaqar/+spec/add-missing-unit-tests )

Changed in zaqar:
assignee: nobody → Sphoorti (sphoorti-joglekar)
Changed in zaqar:
status: New → Confirmed
Changed in zaqar:
importance: Undecided → Medium
Revision history for this message
Flavio Percoco (flaper87) wrote :

@Sphoorti are you actively working on this?

tags: added: low-hanging-fruit
Changed in zaqar:
milestone: none → kilo-1
Revision history for this message
Sphoorti (sphoorti-joglekar) wrote :

Currently I can't work on this. Hence unassigning myself.

Changed in zaqar:
assignee: Sphoorti (sphoorti-joglekar) → nobody
Changed in zaqar:
assignee: nobody → Flavio Percoco (flaper87)
Changed in zaqar:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/135189
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=92c22f54f90320393b0d22648b317c614c9e4932
Submitter: Jenkins
Branch: master

commit 92c22f54f90320393b0d22648b317c614c9e4932
Author: Flavio Percoco <email address hidden>
Date: Tue Nov 18 09:05:32 2014 +0100

    Test message delete when claim expires

    The patch adds a test for message deletion after a claim has expired.
    The result of the test is that the message should be deleted.

    Unfortunately, some issues related to the state of the sqlalchemy driver
    make it quite hard for this test to work there without further changes.
    I'm proposing this patch with some skips in place for the scenarios
    where sqlalchemy is required, I'll propose a follow up patch to fix
    those issues and enable these tests.

    Closes-bug: #1369536

    Change-Id: Icb12eed18c37455ad3528fa6a84fb8f2d8fcf19f

Changed in zaqar:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in zaqar:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.