[wsgi] Duplicate config options relating to max Content-Length

Bug #1270260 reported by Kurt Griffiths on 2014-01-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Medium
Kurt Griffiths
Icehouse
Medium
Kurt Griffiths

Bug Description

These are no longer needed in light of our redifinition of max message and metadata sizes, and indeed have been the source of some confusion and bugs.

# Maximum Content-Length allowed for metadata updating and
# message posting.
;metadata_max_length = 65536
;content_max_length = 262144

Fix proposed to branch: master
Review: https://review.openstack.org/67597

Changed in marconi:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/70463
Committed: https://git.openstack.org/cgit/openstack/marconi/commit/?id=a8d21ee29698f972eb7a535edaec184259b6ae51
Submitter: Jenkins
Branch: master

commit a8d21ee29698f972eb7a535edaec184259b6ae51
Author: kgriffs <email address hidden>
Date: Fri Jan 17 16:50:58 2014 -0600

    fix(wsgi): Cleanup limit config options

    This patch contains several misc. changes to queue, message, and
    claim limits to reduce confusion and bring the implementation in
    line with the v1 spec.

    1. Removed a couple of WSGI driver config options that are
    no longer needed now that we have redefined (and simplified) how
    we constrain message and metadata size.

        metadata_max_length = 65536
        content_max_length = 262144

    2. Renamed options to be more readable and consistent
    3. Moved options to [transport] section
    4. Made max messages that can be claimed its own setting, to reduce confusion
    5. Removed enforcing an upper limit on the number of messages that can be
    posted; this was never in the spec, and appears to be gold-plating. Now, the
    only upper limit is max_message_size.
    6. Removed the check on the size of a create claim request since (1) it is
    not part of the API spec, and (2) sanity-checks like that are best done by
    the web server, before a request even touches the app.
    7. Migrated limits for storage driver interface params to static values,
    since those defaults define the static contract between transport and
    storage drivers.
    8. Wrapped validation error messages in gettextutils._, and converted them
    to use .format instead of %.

    Change-Id: I1372e5002f030f5c8c47774ab00ca8ee7e12232d
    Closes-Bug: #1270260

Changed in marconi:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-03-05
Changed in marconi:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in marconi:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers