Message size validation needs to be redefined

Bug #1261579 reported by Kurt Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
Flavio Percoco
Icehouse
Fix Released
High
Flavio Percoco

Bug Description

As agreed in team discussions:

1. Change API spec to define max message posting size in terms of entire request body, including whitespace; remove per-message size limit
2. Change validation in code per the above.

Changed in marconi:
assignee: nobody → Flavio Percoco (flaper87)
Revision history for this message
Kurt Griffiths (kgriffs) wrote :

This should be fixed under v1.1 API - let's leave 1.0 behavior in place.

Changed in marconi:
status: Triaged → In Progress
Revision history for this message
Kurt Griffiths (kgriffs) wrote :

Docs updated

Revision history for this message
Kurt Griffiths (kgriffs) wrote :

Due to a fateful bug, current behavior is actually doing this, so we can put it into 1.0 (clients will not break)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/65674
Committed: https://git.openstack.org/cgit/openstack/marconi/commit/?id=9205b0c3a3b46c541ec95a0e19db08064887f232
Submitter: Jenkins
Branch: master

commit 9205b0c3a3b46c541ec95a0e19db08064887f232
Author: Flavio Percoco <email address hidden>
Date: Thu Jan 9 13:15:51 2014 +0100

    Enforce size verification on content-length

    Closes-Bug: #1261579

    Previously, Marconi used to enforce the message and queue size limit on
    the resource itself. In the case of a Message, it'd verify that the
    message body wouldn't exceed the message size limit. This enforcement
    has been moved, by this patch, up to the request size.

    For both cases, the content_length is required to be smaller than the
    size limit configured by the service admin. None of the default values
    were modified.

    Change-Id: I06e28acaac234242a40cd2afafb12be067851c20

Changed in marconi:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in marconi:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in marconi:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.