Get Stats call is returning negative value for age

Bug #1237620 reported by Amit Gandhi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
Kurt Griffiths

Bug Description

Stats call returns a negative value for the age

Revision history for this message
Kurt Griffiths (kgriffs) wrote :

The problem is in stat_message the math is reversed:

age = created - now

We need to add a regression test for this, and then fix it, obviously.

Changed in marconi:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → Critical
importance: Critical → High
Kurt Griffiths (kgriffs)
Changed in marconi:
assignee: nobody → Kurt Griffiths (kgriffs)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to marconi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50790

Changed in marconi:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/50790
Committed: http://github.com/openstack/marconi/commit/33f75cd5927e129e6de4fe2116abb5159fa0061a
Submitter: Jenkins
Branch: master

commit 33f75cd5927e129e6de4fe2116abb5159fa0061a
Author: kgriffs <email address hidden>
Date: Wed Oct 9 20:32:59 2013 -0400

    fix(mongo): Negative age reported in stats

    This patch includes a one-line fix, along with a regression test
    to verify the same.

    Change-Id: Iffb3cb7c243296b1caacc95e1edd3c6f63c34a4b
    Closes-Bug: #1237620

Changed in marconi:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to marconi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50995

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/50995
Committed: http://github.com/openstack/marconi/commit/2f844e1ef97f160fdcc728b40ebc91fc2253e5e4
Submitter: Jenkins
Branch: master

commit 2f844e1ef97f160fdcc728b40ebc91fc2253e5e4
Author: Malini Kamalambal <email address hidden>
Date: Thu Oct 10 13:45:30 2013 -0400

    Validation for messages returned by queue/stats

    This patch updates the queue/stats tests to include validation for message age
    (0 <= age <= message_ttl_max), href & created time.

    Tests Bug: #1237620

    Change-Id: I7c6dfd10b94c8ac64247d687ac31783522b8f3d0

Thierry Carrez (ttx)
Changed in marconi:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in marconi:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.