[proxy] Queues are duplicated

Bug #1234849 reported by Allele Dev on 2013-10-03
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Allele Dev

Bug Description


Given a setup involving more than one partition, a marconi-proxy will duplicate queues because it fails to check the catalogue before attempting to create those queues.


0. Set up an environment with multiple partitions and a proxy with those partitions registered to it.
1. http put $proxy/v1/queues/taco
  * Repeat this

Expected Outcome

HTTP 204: No Content

Actual Outcome

HTTP 201: Created # for each partition registered

Allele Dev (alleledev) on 2013-10-03
Changed in marconi:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Alejandro Cabrera (cpp-cabrera)

Fix proposed to branch: master
Review: https://review.openstack.org/49599

Changed in marconi:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/49599
Committed: http://github.com/openstack/marconi/commit/5761d3784967255e78fb85ae8402bcd82e5c3057
Submitter: Jenkins
Branch: master

commit 5761d3784967255e78fb85ae8402bcd82e5c3057
Author: Alejandro Cabrera <email address hidden>
Date: Thu Oct 3 13:59:25 2013 -0400

    fix: do not duplicate queues across partitions

    This patch fixes a proxy bug that allows queues to be duplicated
    across partitions. This happens because the catalogue isn't checked
    for project/queue existence before forwarding requests to a marconi

    Caching is also added to queue on_put to quickly determine if a
    particular project/queue exists.

    A unit test suite is added that verifies that this has been fixed, as
    well as checking various properties on the queue resource.

    Closes-Bug: 1234849
    Partially-Implements blueprint placement-service

    Change-Id: I2e8ca29abd58ecb6f33f0f296119e341504ea3fd

Changed in marconi:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-12-19
Changed in marconi:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in marconi:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers