perf: Loglines are prepared regardless of log level
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| zaqar |
Low
|
Zhihao Yuan |
Bug Description
Log messages are typically formatted regardless of whether they will actually be written out, depending on the effective log level
It would be nice if we could make the formatting conditional, perhaps by extending the logger so it accepts two parameters : the template and the params to substitute into that template.
Changed in marconi: | |
status: | New → Triaged |
Flavio Percoco (flaper87) wrote : | #1 |
Changed in marconi: | |
assignee: | nobody → Zhihao Yuan (zyuan) |
Fix proposed to branch: master
Review: https:/
Changed in marconi: | |
status: | Triaged → In Progress |
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 3b111c3ac1ff117
Author: Zhihao Yuan <email address hidden>
Date: Mon Oct 28 19:02:56 2013 -0400
feat(logging): format msg when log level met
This is a feature supported by the logging module; just let the
logging function perform the formatting.
Change-Id: I9e349c6bda9424
Closes-Bug: 1232327
Changed in marconi: | |
status: | In Progress → Fix Committed |
Changed in marconi: | |
milestone: | none → icehouse-1 |
status: | Fix Committed → Fix Released |
Changed in marconi: | |
milestone: | icehouse-1 → 2014.1 |
There's some work going on i18n and lazy translation / formatting, IIRC. I think that should help with most of the cases. For all the other cases, I think this is a great idea.
Also, this sounds like something we could send to oslo-incubator.