localtz() function doesnt work properly

[Radovan Pieter]

Hi, i came across problem with localtz() function. Per your documentation I understand localtz() function returns timezone information by returning offset seconds to UTC TZ.

But in code there's bad if statement (line 325: https://opendev.org/openstack/yaql/src/branch/master/yaql/standard_library/date_time.py#L325) - there is used parameter "time.daylight" which does NOT indicate whether there is currently DST active. It only (per issues found on internet) indicates whether the TZ does or does not have DST.

You should better use time.localtime().tm_isdst which really indicates if DST is active or not.

- We have usecase where we use yaql localtz() to get current time: now(offset=>localtz()).format("%Y-%m-%d %H:%M")
-- But this approach is not correct now because it now return DST time (so +1hour to real time).
Issue i reffered to: https://bugs.python.org/issue7229

----

Closes-Bug: #2052593

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/yaql/+/908288
Committed: https://opendev.org/openstack/yaql/commit/269f9669965a6d757ff8aaa6683f37b8e9a0f27d
Submitter: "Zuul (22348)"
Branch: master

commit 269f9669965a6d757ff8aaa6683f37b8e9a0f27d
Author: Radovan Pieter <email address hidden>
Date: Wed Feb 7 12:09:27 2024 +0100

    Fix localtz() function

    Closes-Bug: #2052593
    Change-Id: I739b44829202f0edba94ff502cd06e6cba60a4d0