StepDisplacer assumes use of NewtonIntegrator

Bug #706937 reported by Jérôme Duriez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yade
Fix Released
Undecided
Unassigned

Bug Description

Not a big bug, but...

StepDisplacer engine makes a difference between dynamic and nondynamic bodies, to be consistent with what does NewtonIntegrator engine. But it is checked nowhere in StepDisplacer, that NewtonIntegrator is indeed used. For cases where it is not the case, the effects of StepDisplacer are not those presented.

I admit that it is a quite particular case...

Revision history for this message
Jérôme Duriez (jduriez) wrote :

In fact, the difference lies rather on this bool setVelocities... But it does not change what I wanted to point out

Revision history for this message
Jérôme Duriez (jduriez) wrote :

And in fact, the doc is not consistent with the code, since the doc states clearly that a difference is made between dynamic and non dynamic bodies, whereas it is not the case in the code (this made me confused, then the previous comment)

Revision history for this message
Václav Šmilauer (eudoxos) wrote :

Hi Jerome, you are welcome to update the documentation. Since non-dynamic bodies don't exist anymore, that distinction should disappear from the doc. The necessity of using NewotnIntegrator is connected to that, since it is only the intergrator that changes positions (based on velocities).

You can use LawTester instead of StepDisplacer, it is a bit more general, and definitely maintained (unlike StepDisplacer).

Revision history for this message
Jérôme Duriez (jduriez) wrote :

Few changes done in r2690. Closing

Changed in yade:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.