Inconsistency in doc of Body::intrs and code InteractionContainer::insert

Bug #1738232 reported by Jan Stránský on 2017-12-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yade
Undecided
Unassigned

Bug Description

Hello,

in the docs of Body [1] there is

"NOTE: (currently) does not contain all interactions with this body (only those where otherId>id), since performance issues with such data duplication have not yet been investigated."

but in the InteractionContainer::insert, the opposite id is added to both bodies [2,3].

Is the documentation wrong?

cheers
Jan

[1] https://github.com/yade/trunk/blob/master/core/Body.hpp#L89
[2] https://github.com/yade/trunk/blob/master/core/InteractionContainer.cpp#L22
[3] https://github.com/yade/trunk/blob/master/core/InteractionContainer.cpp#L23

Bruno Chareyre (bruno-chareyre) wrote :

Hi Jan,
[1] was true at some point, but it is wrong now.
B

Jan Stránský (honzik) wrote :

Hi Bruno, thanks for info, I have updated the docstring
Jan

Changed in yade:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers