CapillaryTriaxialTest preprocessor broken

[Jérôme Duriez]

Hi,

When using either yadedaily or the latest (as of today) trunk version, CapillaryTriaxialTest preprocessor crashes at the first iteration. The backtrace obtained from a debug version of trunk is attached.

I'm at the moment playing with capillary code before commit capillary scripts, but this crash happens with or without the "water" attribute of the preprocessor, ie with or without capillary Law2 in the engines, and with both yadedaily and trunk, so I do not think it's related.

The crash occurs by the way during some IGeom operations, and the structure of O.engines defined by the preprocessor looks quite outdated (no InteractionLoop()).

Anyway, I would happily hear from you that the same bug exists on other computers.

Jerome

[Bruno Chareyre (bruno-chareyre)]

Confirmed with yadedaily.
Do you remember the latest commits where changes have been made?
Bruno

[Jérôme Duriez (jduriez)]

They are 2 years old:
https://github.com/yade/trunk/commits/master/pkg/dem/CapillaryTriaxialTest.hpp
https://github.com/yade/trunk/commits/master/pkg/dem/CapillaryTriaxialTest.cpp

As for myself, in particular, I never touched them (except for the stress sign convention thing).

I think this preprocessor is simply deprecated, with the engine list declaration being now not consistent with YADE architecture. There is no InteractionLoop definition for instance (as opposed to TriaxialTest other preprocessor)

[Jérôme Duriez (jduriez)]

Regarding this bug, I think the CapillaryTriaxialTest preprocessor does not add much to Yade now (even in a working state), and propose to remove CapillaryTriaxialTest.*pp from the code.
Either using git rm, or adding #ifdef DEPREC_CODE (I vote for the former)

Agree ?

[Jérôme Duriez (jduriez)]

(I'm answering here to http://<email address hidden>/msg12167.html that does not appear on the bug webpage ?)

From my point of view, I do not propose at all to hide a bug.

My understanding of the situation is that CapillaryTriaxialTest preprocessor had not been updated when necessary to reflect YADE changes, contrary to e.g. TriaxialTest preprocessor. As I said, CapillaryTriaxialTest does not include any InteractionLoop, for instance (TriaxialTest obviously does).

If I'm right, solving the "bug" would just require to update the engines definition of CapillaryTriaxialTest, to reflect the current YADE architecture. Since we already have working TriaxialTest preprocessor and examples/capillaryLaplaceYoung folder, I do not see the point fixing the CapillaryTriaxialTest preprocessor in this sense, hence my previous proposition.

[Jérôme Duriez (jduriez)]

Actually, I think the present bug is the same as the newly reported https://bugs.launchpad.net/yade/+bug/1764753

Out of 4 FileGenerator, we have

- two conforming the "new" (though years old) InteractionLoop definition, and that run: TriaxialTest and SimpleShear

- two not conforming this definition but still directly including IGeom, IPhys, and Law2 classes directly in the engines list, and that segfault: CapillaryTriaxialTest and CohesiveTriaxialTest.
And in these two buggy FileGenerators, crashs seem to occur in connection with IGeom operations..

Do we now agree to (try to ?) fix these FileGenerators with the new InteractionLoop definition, if not discarding them ?

[Bruno Chareyre (bruno-chareyre)]

Hi,
I agree to fix or remove.
I will not fix.
If no one else will you can remove. :)
B

[Jérôme Duriez (jduriez)]

Fixed in https://github.com/yade/trunk/commit/12ed7b43ebfe25d5566950dce2d0e489519359c1.

Thanks