particleSD2 (always random + no example script)

[Bruno Chareyre]

(reported by Wenrui Zhu )
particleSD2 takes a "seed" value in arguments, but the result is always random with or wothout seed.

More generally, I (Bruno) wonder if there is really a need to keep many functions for clouds generation. What is PSD2 doing that makeCloud cannot do?
In case there is such special feature, it would be good to have it shown in the psd.py script, since for the moment there is no example of PSD2 usage.

[Chiara Modenese (chiara-modenese)]

On 13 Jul 2012, at 16:53, Chareyre wrote:

> Public bug reported:
>
> (reported by Wenrui Zhu )
> particleSD2 takes a "seed" value in arguments, but the result is always random with or wothout seed.
The seed argument is missing when particleSD is returned at the end of particleSD2 function.

>
> More generally, I (Bruno) wonder if there is really a need to keep many functions for clouds generation. What is PSD2 doing that makeCloud cannot do?
makeCloud() has been recently adapted to 2D generation so I suppose particleSD2 can be removed. Also, I have always been using particleSD so far but actually I can see that everything can be dealt with by makeCloud().

Chiara

> In case there is such special feature, it would be good to have it shown in the psd.py script, since for the moment there is no example of PSD2 usage.
>
> ** Affects: yade
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Yade
> developers, which is the registrant for Yade.
> https://bugs.launchpad.net/bugs/1024443
>
> Title:
> particleSD2 (always random + no example script)
>
> Status in Yet Another Dynamic Engine:
> New
>
> Bug description:
> (reported by Wenrui Zhu )
> particleSD2 takes a "seed" value in arguments, but the result is always random with or wothout seed.
>
> More generally, I (Bruno) wonder if there is really a need to keep many functions for clouds generation. What is PSD2 doing that makeCloud cannot do?
> In case there is such special feature, it would be good to have it shown in the psd.py script, since for the moment there is no example of PSD2 usage.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/yade/+bug/1024443/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~yade-dev
> More help : https://help.launchpad.net/ListHelp

[Bruno Chareyre (bruno-chareyre)]

It is annoying to remove something when it's actually used, because all your scripts will be broken and you'll have to change the line with "particleSD" everywhere.
OTOH, half-working functions are generating useless noise on the mailing list (or in my private mailbox in that case - even if I provided a script with makeCloud initially...).

Could you please decide if you prefer to fix the bug or remove this function (after verifying that you can do what you want with makeCloud)?
Removing the seed parameter would be an acceptable fix, at least it would not mislead anybody.

[Chiara Modenese (chiara-modenese)]

On 13 Jul 2012, at 21:21, Chareyre wrote:

> It is annoying to remove something when it's actually used, because all your scripts will be broken and you'll have to change the line with "particleSD" everywhere.
I agree.
> OTOH, half-working functions are generating useless noise on the mailing list (or in my private mailbox in that case - even if I provided a script with makeCloud initially...).
particleSD() works well as I have extensively used it so far. particleSD2() is the 2D case of the same function, sorry if I overlooked the seed parameter at the time it was introduced.
>
> Could you please decide if you prefer to fix the bug or remove this function (after verifying that you can do what you want with makeCloud)?
For the moment I would prefer to keep the function (maybe somebody else is also using it?). The bug can be fixed by adding the seed parameter to the call of the function particleSD() which is found inside particleSD2() (it is the last parameter in the aforementioned function). The seed parameter is a useful option so I would not remove it. Could you please provide to do the fix? Otherwise I could do it but I am not sure when.

Thanks!
Chiara

> Removing the seed parameter would be an acceptable fix, at least it would not mislead anybody.
>
> --
> You received this bug notification because you are a member of Yade
> developers, which is the registrant for Yade.
> https://bugs.launchpad.net/bugs/1024443
>
> Title:
> particleSD2 (always random + no example script)
>
> Status in Yet Another Dynamic Engine:
> New
>
> Bug description:
> (reported by Wenrui Zhu )
> particleSD2 takes a "seed" value in arguments, but the result is always random with or wothout seed.
>
> More generally, I (Bruno) wonder if there is really a need to keep many functions for clouds generation. What is PSD2 doing that makeCloud cannot do?
> In case there is such special feature, it would be good to have it shown in the psd.py script, since for the moment there is no example of PSD2 usage.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/yade/+bug/1024443/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~yade-dev
> More help : https://help.launchpad.net/ListHelp

[Bruno Chareyre (bruno-chareyre)]

Chiara won't fix?

[Bruno Chareyre (bruno-chareyre)]

The functions are removed in c145f5a